refactor: use id instead of nodeid in client items array #6671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ugur-vaadin
changed the title
ugur-vaadin
changed the title
ugur-vaadin
force-pushed
the
feat/dashboard-keyboard-move-resize
branch
from
8b42dd1 to
98ed9b9
Compare
tomivirkki
approved these changes
Sep 26, 2024
|
ugur-vaadin
added a commit
that referenced
this pull request
Oct 9, 2024
* test: add tests for keyboard move and resize * fix: only update client items when necessary * refactor: use id in items array instead of nodeid * refactor: reintroduce removed client item updates * refactor: use id instead of nodeid in item state changed events * refactor: remove unnecessary equality check
ugur-vaadin
added a commit
that referenced
this pull request
Oct 10, 2024
* test: add tests for keyboard move and resize * fix: only update client items when necessary * refactor: use id in items array instead of nodeid * refactor: reintroduce removed client item updates * refactor: use id instead of nodeid in item state changed events * refactor: remove unnecessary equality check
ugur-vaadin
added a commit
that referenced
this pull request
Oct 10, 2024
* test: add tests for keyboard move and resize * fix: only update client items when necessary * refactor: use id in items array instead of nodeid * refactor: reintroduce removed client item updates * refactor: use id instead of nodeid in item state changed events * refactor: remove unnecessary equality check
ugur-vaadin
added a commit
that referenced
this pull request
Oct 10, 2024
* test: add tests for keyboard move and resize * fix: only update client items when necessary * refactor: use id in items array instead of nodeid * refactor: reintroduce removed client item updates * refactor: use id instead of nodeid in item state changed events * refactor: remove unnecessary equality check
ugur-vaadin
added a commit
that referenced
this pull request
Oct 15, 2024
* test: add tests for keyboard move and resize * fix: only update client items when necessary * refactor: use id in items array instead of nodeid * refactor: reintroduce removed client item updates * refactor: use id instead of nodeid in item state changed events * refactor: remove unnecessary equality check
ugur-vaadin
added a commit
that referenced
this pull request
Oct 15, 2024
* feat: add dashboard packages (#6548) * feat: add dashboard packages * chore: use correct license * refactor: comment out npm package temporarily * refactor: add polymer legacy adapter * chore: remove incorrect npm package * fix: correct the inverted module names * chore: add license to pom * fix: add module to root level pom * chore: run formatter * feat: add packages for testbench and integration tests * fix: update polymer legacy adapter version * chore: remove unused dependency * feat: add title API to dashboard widget (#6560) * feat: add title for widget * chore: run formatter * refactor: use properties instead of attributes * docs: fix the widget title property name * feat: introduce add and remove widget functionality to dashboard (#6572) * feat: introduce add and remove widget functionality to dashboard * fix: add missing lines and run formatter * fix: fix compilation error * chore: run formatter * test: remove first and last widgets and use clickelementswithjs * refactor: make remove from parent use removevirtualchild for widgets * refactor: use append and remove with virtual children and remove from parent before add * chore: remove unused code * refactor: merge attach handlers * refactor: do not try to remove virtual child on detach * refactor: use widgets list to update detach listeners * test: add more unit tests for testing node ids on detach * refactor: use dashboard remove when removing widget from parent * test: use clickelementwithjs without locating element * refactor: remove detach listeners * test: add tests for moving widgets between parents * test: add unit tests for moving widgets between components * test: cleanup dashboard widget related unit tests * refactor: use add remove directly instead of using virtual children * refactor: simplify removing all widgets by reusing single remove logic * refactor: override getchildren * test: remove duplicate test and rename tests (#6585) * fix: handle invalid widget index (#6584) * feat: implement max col count feature (#6581) * feat: implement max col count feature * feat: add getter for maximum column count * Update vaadin-dashboard-flow-parent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com> * Update vaadin-dashboard-flow-parent/vaadin-dashboard-flow/src/main/java/com/vaadin/flow/component/dashboard/Dashboard.java Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com> --------- Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com> * feat: add dashboard widget colspan support (#6591) * feat: add dashboard widget colspan support * test: add getter for colspan to dashboard widget element * test: use computed styles for getting colspan from testbench element * test: add its for getting and updating colspans * test: updated wording for getting colspan from testbench element * feat: add max min column width support (#6594) * feat: add max min column width support * test: remove its * feat: add gap support to dashboard (#6596) * feat: add min row height support to dashboard (#6613) * feat: add dashboard sections support (#6606) * feat: add dashboard sections support * feat: use components to set items on the client side (#6610) * refactor: restore patching virtual container to fix its * test: add its that cover more cases updating the client * refactor: make detach handler implement detach listener * feat: add content support to dashboard widget (#6618) * feat: add content related api to dashboard widget * refactor: make set get content separate from slotted elements * test: update testbench content to check for all slots * feat: add content related api to dashboard widget * refactor: make set get content separate from slotted elements * test: update testbench content to check for all slots * chore: run formatter * test: move tests into appropriate classes * feat: add rowspan support to dashboard widget (#6624) * feat: add content related api to dashboard widget * chore: run formatter * test: move tests into appropriate classes * feat: add rowspan support to dashboard widget * feat: add header support to dashboard widget (#6617) * feat: add content related api to dashboard widget * feat: add header support to dashboard widget * test: fix merge problems * test: add missing buttons to test page * feat: support drag drop for dashboard (#6633) * feat: support drag drop for dashboard * chore: run formatter * test: fix unit test assertion * test: update test route names to align with others * test: add its that test the server client communication * refactor: simplify js event workaround * fix: do not remove widgets on detach * refactor: remove item sanitization on drag reorder * refactor: check children of element and remove workaround * refactor: make dashboard not editable by default * test: use selenium for drag drop and add tests for editable * feat: add drag resize support to dashboard (#6643) * feat: add drag resize support to dashboard * refactor: make resize events return the item instead of node id * refactor: return widget instead of component in resize events * test: simplify resize it page and tests * feat: support dashboard item remove using button (#6650) * feat: support dashboard item remove using button * test: remove tests about visibility of edit buttons * refactor: do not handle clients events if dashboard is not editable (#6656) * refactor: make dashboard implement hassize (#6661) * refactor: throw exception when setting and getting visibility (#6658) * refactor: throw exception when setting and getting visibility * refactor: always return true when isvisible is called * refactor: make section and widget return true for isvisible * refactor: update events based on web component event changes (#6660) * refactor: return reordered items and parent from event * fix: handle the case where drag reorder returns the same items * chore: remove unused code * chore: rename incorrectly named test method * refactor: update events based on web component event changes * refactor: align event apis with web component * chore: run formatter * feat: implement i18n support (#6668) * feat: implement i18n support * test: do not check for default values * refactor: update i18n property names * docs: update wording for i18n methods * feat: implement item mode changed events (#6672) * refactor: use id instead of nodeid in client items array (#6671) * test: add tests for keyboard move and resize * fix: only update client items when necessary * refactor: use id in items array instead of nodeid * refactor: reintroduce removed client item updates * refactor: use id instead of nodeid in item state changed events * refactor: remove unnecessary equality check * feat: add dense layout support to dashboard (#6678) * feat: add dense layout support to dashboard * test: remove dense layout its * refactor: update dense property name * chore: update setter wordings * refactor: rename gap to spacing (#6687) * refactor: rename gap to spacing * docs: update spacing api javadocs * refactor: rename header apis and use header content slot (#6683) * test: fix tests * refactor: use latest web components * test: make test pages larger for consistency * chore: update dashboard package versions * fix: update pom versions * refactor: combine internal remove methods for widget and section * Update vaadin-dashboard-flow-parent/vaadin-dashboard-flow/pom.xml Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> * docs: update event descriptions to specify when they are fired * docs: add descriptions to dashboard classes * docs: update javadocs to explain the index logic for adding widgets * Update vaadin-dashboard-flow-parent/vaadin-dashboard-flow-integration-tests/pom.xml Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> --------- Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com> Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
idin items array instead of a customnodeid, as introduced in the web componentFixes https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=81029438
Part of vaadin/platform#6626
Type of change
Refactor