feat: add i18n error message support for RadioButtonGroup #6477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoCardoso
approved these changes
Jul 26, 2024
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha7 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces RadioButtonGroupI18n with a method for setting a required error message and updates the RadioButtonGroup's validation logic to show this error message when validation fails. It should be mentioned that RadioButtonGroup is an atypical component in terms of validation. It has a required flag, but no user interaction can trigger the required error message – the message only appears if the value is programmatically reset to null. Therefore, the i18n object is practically unnecessary, but it's still added to maintain consistency with other components.
Part of #4618
Type of change