fix: Use incremental numeric id as a key for Tree Grid items (#3046) (CP: 14.8) #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Use incremental numeric id as a key for Tree Grid items Using Object::toString as an item's key for server-client communication makes item's data visible on the client side, so generated numeric id is used instead. * Use serializable map * Use index and depth as an item ID * fix data provider getId implementation * use custom unique key provider in tests Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com> Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> (cherry picked from commit 8fe0861)
DiegoCardoso
approved these changes
May 4, 2022
|
This ticket/PR has been released with Vaadin 14.8.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of: #3046
(cherry picked from commit 8fe0861)