Skip to content

Commit

Permalink
breaking: Dropped support for Node <18
Browse files Browse the repository at this point in the history
  • Loading branch information
vHeemstra authored Dec 2, 2023
2 parents 57899ef + d886027 commit f10ff95
Show file tree
Hide file tree
Showing 8 changed files with 3,151 additions and 1,429 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci_coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
cache: npm

- name: Install dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci_create_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
cache: npm
registry-url: https://registry.npmjs.org
- name: Install dependencies
Expand All @@ -36,7 +36,7 @@ jobs:
# - name: Install Node.js
# uses: actions/setup-node@v4
# with:
# node-version: 16.x
# node-version: 20.x
# cache: npm
# scope: '@vHeemstra'
# registry-url: https://npm.pkg.github.com
Expand Down
14 changes: 8 additions & 6 deletions .github/workflows/ci_pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
cache: npm
- name: Install dependencies
run: npm ci
Expand All @@ -44,7 +44,9 @@ jobs:
node-version:
# - 12.x
# - 14.x
- 16.x
# - 16.x
- 18.x
- 20.x
os:
- ubuntu-latest
- windows-latest
Expand All @@ -67,23 +69,23 @@ jobs:
run: npm ci

- name: Run Jest
if: matrix.os != 'ubuntu-latest' || matrix.node-version != '16.x'
if: matrix.os != 'ubuntu-latest' || matrix.node-version != '20.x'
run: npm test

- name: Run Jest with coverage
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16.x'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
run: npm test -- --coverage

# Save coverage report in Coveralls
- name: Coveralls
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16.x'
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: ./test/coverage/lcov.info

# - name: Codecov
# if: matrix.os == 'ubuntu-latest' && matrix.node-version == '16.x'
# if: matrix.os == 'ubuntu-latest' && matrix.node-version == '20.x'
# uses: codecov/codecov-action@v2
# with:
# directory: ./test/coverage/
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/ci_push_on_main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
cache: npm
- name: Install dependencies
run: npm ci
Expand All @@ -43,7 +43,9 @@ jobs:
node-version:
# - 12.x
# - 14.x
- 16.x
# - 16.x
- 18.x
- 20.x
os:
- ubuntu-latest
- windows-latest
Expand Down Expand Up @@ -85,7 +87,7 @@ jobs:
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
cache: npm
registry-url: https://registry.npmjs.org/

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/combine_prs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:

# # In: - Out: JSON-encoded string
# - name: Run custom js
# uses: actions/github-script@v6
# uses: actions/github-script@v7
# id: vhw-test
# env:
# SOME_ENV: 'jaja'
Expand All @@ -84,7 +84,7 @@ jobs:
# echo $TEST2;

- name: Fetch branch names
uses: actions/github-script@v6
uses: actions/github-script@v7
id: fetch-branch-names
with:
# github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
Expand Down Expand Up @@ -329,7 +329,7 @@ jobs:
git push origin $COMBINE_BRANCH_NAME
# Creates a PR with the new combined branch
- uses: actions/github-script@v6
- uses: actions/github-script@v7
name: Create Combined Pull Request
env:
BASE_BRANCH: ${{ steps.fetch-branch-names.outputs.base-branch }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:


- name: Analyze and label PR
uses: actions/github-script@v6
uses: actions/github-script@v7
id: label-pr
with:
# github-token: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
Expand Down
Loading

0 comments on commit f10ff95

Please sign in to comment.