Add visual debugging for entities #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kokosha
commented
Dec 14, 2024
•
kokosha
commented
- Display rectangles and bounding boxes for the sprites of each entity.
- Highlight the center of each bounding box and create an axis to facilitate alignment verification.
- Implement a mode where billboards always faces the current camera.
- Reduce the billboard size for the player entity.
- Refactor the code to reuse existing functions.
- Convert sRGB to linear color inside AABB/Circle/Rectangle pipeline.
kokosha
force-pushed
the
entity-billbox
branch
from
e0f3187 to
2a93f4e
Compare
|
The shader looks like it's a general purpose "rectangle" shader, like the AABB and circle shader. We could then use it the same way we already use the other two debug shader. |
kokosha
force-pushed
the
entity-billbox
branch
2 times, most recently
from
64948b4 to
a42b71d
Compare
hasenbanck
requested changes
Dec 15, 2024
hasenbanck
changed the title
|
Please squash, rebase and use the updated title of the issue for the commit message once you are finished! |
|
I change the variable naming also for better readability and will rebase on top of it. |
kokosha
force-pushed
the
entity-billbox
branch
2 times, most recently
from
8334b3b to
13f7d3b
Compare
- Display rectangles and bounding boxes for the sprites of each entity. - Highlight the center of each bounding box and create an axis to facilitate alignment verification. - Implement a mode where billboards always faces the current camera. - Reduce the billboard size for the player entity. - Refactor the code to reuse existing functions. - Convert sRGB to linear color inside AABB/Circle/Rectangle pipeline.
kokosha
force-pushed
the
entity-billbox
branch
from
13f7d3b to
6643647
Compare
|
LGTM |
hasenbanck
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.