Skip to content

Commit

Permalink
[wasm-simd][ia32] Fix all_true operand to be register
Browse files Browse the repository at this point in the history
all_true uses pcmpeqd which takes a memory operand, but needs to be
128-bit aligned, which we don't support yet.

Bug: v8:9198
Change-Id: Ia0caaaa76b1103ba538252181ef93e8557fb4739
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2218887
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68027}
  • Loading branch information
ngzhian authored and Commit Bot committed May 27, 2020
1 parent fbdefae commit d4b58fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/compiler/backend/ia32/instruction-selector-ia32.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2407,7 +2407,7 @@ SIMD_ANYTRUE_LIST(VISIT_SIMD_ANYTRUE)
IA32OperandGenerator g(this); \
InstructionOperand temps[] = {g.TempRegister(), g.TempSimd128Register()}; \
Emit(kIA32##Opcode, g.DefineAsRegister(node), \
g.UseUnique(node->InputAt(0)), arraysize(temps), temps); \
g.UseUniqueRegister(node->InputAt(0)), arraysize(temps), temps); \
}
SIMD_ALLTRUE_LIST(VISIT_SIMD_ALLTRUE)
#undef VISIT_SIMD_ALLTRUE
Expand Down

0 comments on commit d4b58fe

Please sign in to comment.