Set JSON_DIAGNOSTICS=ON breaks graphscope

[sighingnow]

Describe your problem

We have noticed failure on GraphScope with vineyard v0.2.5:

WARNING: Logging before InitGoogleLogging() is written to STDERR
I0701 21:14:29.332938 734798 htap_ds_impl.cc:31] enter get_graph_handle
I0701 21:14:29.333325 734798 htap_ds_impl.cc:34] Initialize vineyard client
I0701 21:14:29.500212 734798 htap_ds_impl.cc:38] Get vineyard object ok: 0x7fd8e8003d20
I0701 21:14:29.500243 734798 htap_ds_impl.cc:42] FragGroup: total frag num = 2, vertex label num = 4, edge label num = 4
I0701 21:14:29.500257 734798 htap_ds_impl.cc:81] fid = 0, instance_id = 0, location = 0
I0701 21:14:29.557229 734798 htap_ds_impl.cc:88] begin construct fragment: 37884725264101546, vineyard::ArrowFragment<long,unsigned long>
I0701 21:14:29.609493 734798 htap_ds_impl.cc:96] begin get vertex map: 37884719647632416
I0701 21:14:29.613639 734798 htap_ds_impl.cc:101] begin construct vertex map: 37884719647632416
I0701 21:14:29.615562 734798 htap_ds_impl.cc:106] finish construct vertex map: 37884725264101546
executor: /usr/local/include/nlohmann/json.hpp:1253: void nlohmann::basic_json<ObjectType, ArrayType, StringType, BooleanType, NumberIntegerType, NumberUnsignedType, NumberFloatType, AllocatorType, JSONSerializer, BinaryType>::assert_invariant(bool) const [with ObjectType = std::map; ArrayType = std::vector; StringType = std::__cxx11::basic_string<char>; BooleanType = bool; NumberIntegerType = long int; NumberUnsignedType = long unsigned int; NumberFloatType = double; AllocatorType = std::allocator; JSONSerializer = nlohmann::adl_serializer; BinaryType = std::vector<unsigned char>]: Assertion `!check_parents || !is_structured() || std::all_of(begin(), end(), [this](const basic_json & j) { return j.m_parent == this; })' failed.

The difference should be we enabled JSON_DIAGNOSTICS for nlohmann::json.

Additional context

Add any other context about the problem here.

[sighingnow]

The issue should come from upstream: nlohmann/json#2838

[sighingnow]

Will be fixed by upgrading the nlohmann/json submodule after it get fixed in upstream.

[sighingnow]

Closed as fixed by upstream.