[Httpclient] fix pointer position of mmap object in the case of failure #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxtkr77
reviewed
Mar 27, 2024
gtopper
reviewed
Mar 27, 2024
gtopper
reviewed
Mar 31, 2024
Co-authored-by: Gal Topper <gal.topper@gmail.com>
gtopper
approved these changes
Mar 31, 2024
alxtkr77
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ML-5926
When using an mmap object, this bug might occur:
If the first connection fails, the pointer still moves at the first attempt by the first connection's block size. After it fails, we try to create another connection and send data, but not from the beginning of the file.
This is why we might miss some bytes at the beginning of the file.
This PR solves the issue and explains it with comments.