-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add StatsService.GetSysStats #1794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pull request is ready to be merged.
This pull request have added a 3 second timeout to grpc request in v2ctl. I believe this behavior should be reflected in document to prevent confusion in the future. |
Actually the previous behavior is more confusing, grpc dial have a infinite timeout, the command just hangs forever. |
Yes, however, we can't assume all commands can be completed in 3 seconds. |
I think we can. Any cli command does not response in a human bearable time and tells what happened, is bad design. A three seconds waiting is suitable in this situation. |
Currently, this is the case, but I think this change should be documented nonetheless. |
a notice line added, heres the help text:
|
I believe this pull request is ready to be merged. |
StatsService.GetSysStats
call tov2ctl
to retrieve core running data, example:v2ctl api
without arguments, hangs forever with no output/error.