-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specification of odd length boundary padding in MatrixWavedec #97
Conversation
I find the naming of the argument |
Could we just call it orthogonalization instead of boundary? boundary_orthogonalization is too much to type. |
I have made a few changes. What do you think? |
I also added the deprecation warning to the packets and added more tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR is ready for a merge.
I did some minor tweaks for consistency and renamed I think this PR is good to go. |
Addresses #90.
In sparse-matrix based wavelet decompositions, we require all transformed approximations coefficients to be of even length. This is enforced by padding a single value along all axes with odd lengths.
Currently, this is always done by zero padding. This PR adds the option to specify a different padding type.
This also makes it easier to document the padding behaviour.