Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve packets order interface #95

Merged
merged 10 commits into from
Jun 26, 2024
Merged

Improve packets order interface #95

merged 10 commits into from
Jun 26, 2024

Conversation

felixblanke
Copy link
Collaborator

  • Makes WaveletPacket.get_level static
  • Adds Option for WaveletPacket.get_level to return the 1d natural order.
  • Adds WaveletPacket2D.get_level to have a consistent interface (with our 1d case as well as pywt)
  • Adds unit tests for both 1d orders and 2d natural order

@felixblanke felixblanke added the enhancement New feature or request label Jun 25, 2024
@v0lta v0lta self-assigned this Jun 26, 2024
@v0lta
Copy link
Owner

v0lta commented Jun 26, 2024

Thanks, I like this PR. It introduces pywt compatible interfaces, which will make it easier to switch. I merged the main, and so far, all tests have checked out.

@v0lta v0lta self-requested a review June 26, 2024 13:57
Copy link
Owner

@v0lta v0lta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is ready to be merged.

@v0lta v0lta merged commit 4e271a8 into main Jun 26, 2024
7 checks passed
@v0lta v0lta deleted the feature/packets-level-order branch June 26, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants