Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem propagating the "product_version" attribute #1737

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

meaksh
Copy link
Member

@meaksh meaksh commented Oct 11, 2024

What does this PR change?

I've noticed there was a problem where the product_version was not set properly on the deployed nodes when not having a product_version definition in the "base" module but instead inside each different nodes.

Like in this example:

module "base" {
[... no product_version defined here ...]
}

module "suma-43-srv" {
  source = "./modules/server"
  base_configuration = module.base.configuration

  name = "suma-43-srv"
  product_version = "4.3-nightly"
}

module "suma-43-min-build" {
  source = "./modules/build_host"
  base_configuration = module.base.configuration

  name = "suma-43-min-build"
  product_version = "4.3-released"
  server_configuration = module.suma-43-srv.configuration
  image = "sles15sp4o"
}

module "suma-43-min-host" {
  source = "./modules/host"
  base_configuration = module.base.configuration

  name = "suma-43-min-host"
  image = "sles15sp4o"
}

Before this PR, i.a. the suma-43-srv node was not deploying correctly, as it got product_version = "" and therefore not installing the SERVER stack.

This PR should fix this problem and use the product_version from the node if defined, if note take the one from "base" module.

Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@maximenoel8 maximenoel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I missed getting the variable to backend host. Sorry .

@meaksh meaksh merged commit 3e3118d into master Oct 14, 2024
2 checks passed
@meaksh meaksh deleted the master-fix-default-product_version-value branch October 14, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants