Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set auto_connect_to_master to False for sshminion #1718

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/sshminion/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ variable "product_version" {

variable "auto_connect_to_master" {
description = "whether this minion should automatically connect to the Salt Master upon deployment"
default = true
default = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the default? our CI can set the variable to everything it's wanted in there. Changing the default means each developer that want to setup a fast environment will need to set the flag or manually onboard. That is going in a different direction of what was in place for Sumaform.

}

variable "use_os_released_updates" {
Expand Down
Loading