Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove openSUSE Leap 15.4 due to EOL #1686

Closed
wants to merge 3 commits into from

Conversation

nodeg
Copy link
Member

@nodeg nodeg commented Sep 9, 2024

What does this PR change?

openSUSE 15.4 is EOL since the end of 2023. See https://en.opensuse.org/Lifetime
I did not touch the cloud files, though.

@nodeg nodeg self-assigned this Sep 9, 2024
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
@nodeg nodeg marked this pull request as ready for review September 11, 2024 11:17
@nodeg nodeg requested a review from a team September 11, 2024 11:17
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see nitpicks

main.tf.libvirt-testsuite.example Outdated Show resolved Hide resolved
main.tf.libvirt-testsuite.example.Manager-43 Outdated Show resolved Hide resolved
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Signed-off-by: Dominik Gedon <dominik.gedon@suse.com>
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the code in Sumaform tests before merging it.

Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please close. I fixed the PR in #1697

@Bischoff
Copy link
Contributor

I fixed the PR in #1697

@Bischoff Bischoff closed this Sep 13, 2024
@nodeg nodeg deleted the remove-leap154 branch September 13, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants