-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic CI Doc Build #1785
base: main
Are you sure you want to change the base?
Automatic CI Doc Build #1785
Conversation
Doc build CI fail: FileNotFoundError: [Errno 2] No such file or directory: 'doc_version.json' |
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com>
Co-authored-by: ethanglaser <42726565+ethanglaser@users.noreply.github.com>
The relative file paths seem to be adding some instability - is there an advantage to creating a json file over setting an environment variable or something like that? ie remove doc_version.json creation and instead get the environment variable here https://github.com/aepanchi/scikit-learn-intelex/blob/docs-ci/doc/sources/conf.py#L40 |
o.value = entry.url; | ||
if (current_version == entry.version){ | ||
o.selected = true; | ||
optionText = optionText; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't understand this assignment
Co-authored-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@ethanglaser @napetrov CI passes all checks except the doc one. The error is:
But the script creates the file on the next line. |
publish.yml is not being triggered from anywhere - the failing step is from .ci/pipeline/docs.yml which does not include any of the necessary logic |
@aepanchi who will continue to work on this PR? |
Hi @samir-nasibli I don't support scikit learn. Only oneDAL and daal4py |
Thank you! I would like to clarify, is that mean that you are only support |
so I will be approving PRs and customer-reported bugs at the moment |
Hi @samir-nasibli, I double-checked my support, and it says that I cover sci-kit-learn for PR reviews, so I think Ethan might be the best person to take over this PR. Then I can review it |
Description
Enable automatic CI doc build once the main is updated. Propose a better version control solution.
Output is available at https://aepanchi.github.io/scikit-learn-intelex/2024.3/
Changes proposed in this pull request:
.github/workflows/publish.yml
to enable automatic CI doc builddoc/index.html
to redirect user to the latest doc versiondoc/set_version.sh
to set the doc versiondoc/sources/_static/version_switcher.js
anddoc/sources/_templates/versions.html
to switch versionsdoc/versions.json
to specify the doc versions to builddoc/sources/_static/style.css
todoc/sources/_static/custom.css
to align with conf.py; update the file with the version dropdown button configurationsSigned-off-by: Alexandra Epanchinzeva alexandra.epanchinzeva@intel.com