Fix clang-tidy job #645
Merged
Fix clang-tidy job #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldav
force-pushed
the
colin/fix_clang_tidy
branch
3 times, most recently
from
9f47c32 to
d5b6df9
Compare
This was both incorrect and did not work with the new dockers. This replicates our original code in our previous internal CI.
coldav
force-pushed
the
colin/fix_clang_tidy
branch
from
d5b6df9 to
1481fcd
Compare
alan-forbes-cp
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix clang-tidy job
Reason for change
This was both incorrect and did not work with the new dockers.
Description of change
This replicates our original code in our previous internal CI. We cannot reliably get dependencies of clang-tidy targets by grepping for add_dependencies. Luckily, we do not need to: we can simply look for all targets ending in '.cpp' or '.h' instead.