Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UseAuthentication middleware to support sessions #275

Closed
Tracked by #211
asmahood opened this issue May 3, 2024 · 1 comment · Fixed by #291
Closed
Tracked by #211

Update UseAuthentication middleware to support sessions #275

asmahood opened this issue May 3, 2024 · 1 comment · Fixed by #291
Assignees
Labels
type::Feature Issues/Pull requests that implement a new feature/enhancement work::Product Development

Comments

@asmahood
Copy link
Member

asmahood commented May 3, 2024

Description

The UseAuthentication middleware currently verifies that the JWT token is valid. To support session management, this needs to be updated to check for either a session ID or a JWT cookie. If a session ID is present in the request, use the session ID lookup logic. If the cookie is a JWT, use the existing JWT authentication logic. This is to keep backwards compatibility with the app.

We will remove the JWT logic at a later point.

For details on how this should be modified, view the example sequence diagram.

Approach


Blocks

Blocked By

Related To

@asmahood asmahood added type::Feature Issues/Pull requests that implement a new feature/enhancement work::Product Development labels May 3, 2024
@asmahood
Copy link
Member Author

asmahood commented May 8, 2024

This won't be backwards compatible with the proposed changes. Resolved.

@asmahood asmahood self-assigned this Jul 3, 2024
asmahood added a commit that referenced this issue Jul 3, 2024
Updates the UseAuthentication middleware to add optional support for
session based authentication. The old JWT based authentication is still
in the middleware, and will be removed once the webapp has been updated
to support session based authentication.

Closes #275
asmahood added a commit that referenced this issue Jul 4, 2024
Updates the UseAuthentication middleware to add optional support for
session based authentication. The old JWT based authentication is still
in the middleware, and will be removed once the webapp has been updated
to support session based authentication.

Closes #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::Feature Issues/Pull requests that implement a new feature/enhancement work::Product Development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant