Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update schedule section of cookiecutter #41

Merged
merged 16 commits into from
Jan 13, 2022
Merged

update schedule section of cookiecutter #41

merged 16 commits into from
Jan 13, 2022

Conversation

JessicaS11
Copy link
Contributor

As per this commen from #39

@JessicaS11 JessicaS11 mentioned this pull request Jan 6, 2022
@lsetiawan
Copy link
Contributor

lsetiawan commented Jan 6, 2022

Just copying over the comment from @JessicaS11:

@lsetiawan in my most recent commit I intentionally broke the cookiecutter/splash page by adding a few items to the book/schedule.yaml that aren't currently parsed by the cookiecutter. Would you be able to take on making some changes to the cookiecutter index?

  • make location optional (ideal for virtual events)
  • add a note to the top of the schedule about the timezone (you can just use the one from book/schedule.md for an example, which includes an "in-your-timezone" link); I added a timezone block to the yaml to start this.
  • add an optional video block (or even more generic a resource that allows for a title and url, so it can be used for videos or slides)
  • tell me how (assuming it's possible) to include a list of items in a description, since that's often a great visual way to list a few objectives for a given session

Alternatively, if you'd like to recommend an approach that is not me trying to brute-force, manually write and format html correctly I'd be willing to try and work on some of these. : )

@lsetiawan
Copy link
Contributor

@JessicaS11 I won't have time today to look over this. But I will check it out tomorrow! I think I understand what you're asking. Shouldn't be to difficult 👍🏽

@lsetiawan
Copy link
Contributor

@JessicaS11 I got all your requested features I think. Let me know if I missed anything. Also please help on the build 😭

@JessicaS11 JessicaS11 marked this pull request as ready for review January 10, 2022 20:10
@JessicaS11
Copy link
Contributor Author

Thanks @lsetiawan - this looks great (I am quite satisfied)! It builds fine for me locally, so let's see what GH has to say.

@JessicaS11 JessicaS11 requested a review from scottyhq January 10, 2022 20:23
conda/environment.yml Outdated Show resolved Hide resolved
@JessicaS11
Copy link
Contributor Author

JessicaS11 commented Jan 11, 2022

Anyone know why the "this branch is out of sync with the base" update button isn't showing up? Sure I can merge manually, but that button is mighty handy...

@scottyhq
Copy link
Contributor

Anyone know why the "this branch is out of sync with the base"

Not sure, but if you can merge the current main branch in that would be great!

@jomey
Copy link
Contributor

jomey commented Jan 12, 2022

Anyone know why the "this branch is out of sync with the base"

Not sure, but if you can merge the current main branch in that would be great!

Far fetched guess is that there might be a merge conflict, which needs be resolved locally and hence no button here?

UPDATE: As i typed this the button appeared. GitHub hiccup?

@lsetiawan
Copy link
Contributor

Oops 🙊 hopefully that didn't mess anything up... I pressed the update branch button thing! Sorry!

@JessicaS11
Copy link
Contributor Author

Oops 🙊 hopefully that didn't mess anything up... I pressed the update branch button thing! Sorry!

Perfect! I was lamenting the lack of update branch button!

@jomey
Copy link
Contributor

jomey commented Jan 12, 2022

Jessica, after editing the environment.yml there needs to be an update to the .lock files.
Execute the lock-environment.sh script and commit the changes. Note, that you need to be inside the conda folder when executing.

conda/environment.yml Outdated Show resolved Hide resolved
@JessicaS11 JessicaS11 requested a review from jomey January 12, 2022 21:50
@jomey jomey added the preview label Jan 12, 2022
@github-actions
Copy link

@JessicaS11 JessicaS11 merged commit 1e1936d into main Jan 13, 2022
@JessicaS11 JessicaS11 deleted the sched-cookie branch January 13, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants