-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the query kill test #884
base: integration_tests
Are you sure you want to change the base?
added the query kill test #884
Conversation
…integration_tests
uwescience/myria-python#61 has been merged and a new release of myria-python pushed to pypi. |
""" | ||
plan = self.connection.compile_program(program) | ||
# We submit with submit_plan so as to not block | ||
query = MyriaQuery.submit_plan(plan) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to just call a nonblocking MyriaQuery
API with the program string. I guess this could be done in myria-python
by either adding a new method to MyriaQuery
that just generates the plan and calls MyriaConnection.submit_query()
, or by adding a nonblocking version of MyriaConnection.execute_program()
. @BrandonHaynes could you weigh in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we support asynchronous execution in MyriaQuery
but not in the connection facade. I'll update MyriaConnection.execute_program
to support this and add an overload to MyriaQuery.submit_query
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nonblocking overload added in uwescience/myria-python#62
x = [0 as exp, 1 as val]; | ||
do | ||
x = [from x emit exp+1 as exp, 2*val as val]; | ||
while [from x emit max(exp) < 1000]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May as well make this limit humongous (say a billion) to avoid races, since we're going to kill it at the first opportunity.
ebffaa5
to
1613e3d
Compare
Requires the python api query kill to be added (uwescience/myria-python#61)
@BrandonHaynes @senderista