Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Various bug fixes #236

Merged
merged 1 commit into from
Jul 12, 2022
Merged

[Fix] Various bug fixes #236

merged 1 commit into from
Jul 12, 2022

Conversation

OustanDing
Copy link
Member

@OustanDing OustanDing commented Jul 12, 2022 •
edited
Loading

Notion ticket link

Ticket

Implementation description

  • Review information step: Guardian information card should just show “No guardian/POA”, no edit button or add button
  • Review information step: Additional information card should not have Edit button
  • Processing tasks: Receipt number should be of format HHMMSS-ID
  • Permit holder page: Gender needs to be TitleCase
  • Complete application: Permanent permit expiry date must be last day of month 3 years from now
    • Also show the expected permit expiry date for pending and in-progress applications
  • Processing tasks: Do not allow assigning APP number to a permit number that already exists
  • Account report: Add $ signs to monetary amounts
  • Report generation: All report end date filters should include the end date
  • Permit holders table: Remove email field

Notes

  • Following meeting and feedback from RCD

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@OustanDing OustanDing merged commit 3448b6c into staging Jul 12, 2022
@OustanDing OustanDing deleted the od/fix/various-rcd-bug-fixes branch July 12, 2022 04:41
@OustanDing OustanDing added the ready to merge ✅ Ready to merge (all reviews received) label Jul 12, 2022
@OustanDing OustanDing mentioned this pull request Jul 31, 2022
Merged
3 tasks
OustanDing added a commit that referenced this pull request Jul 31, 2022
@OustanDing
[Release] Version 0.0.1 (#243)
43f6edb 
* [Fix] Fix replacement application expiry date ([Fix] Fix replacement application expiry date #242)
* [Feature] Build privacy policy and terms and conditions pages ([Feature] Build privacy policy and terms and conditions pages #241)
* [Improvement] Add error logging, improve error handling ([Improvement] Add error logging, improve error handling #240)
* [Fix] Convert patient condition field to checkbox field ([Fix] Convert patient condition field to checkbox field #239)
* [Feature] Add date of birth filter to permit holders page ([Feature] Add date of birth filter to permit holders page #238)
* [Fix] Prevent RCD email from breaking into two lines ([Fix] Prevent RCD email from breaking into two lines #237)
* [Fix] Various bug fixes ([Fix] Various bug fixes #236)
OustanDing added a commit that referenced this pull request Aug 10, 2022
@OustanDing
[Release] Version 0.0.2 (#249)
f264903 
* [Fix] Various bug fixes (#236)

* [Fix] Prevent RCD email from breaking into two lines (#237)

* [Feature] Add date of birth filter to permit holders page (#238)

* [Fix] Convert patient condition field to checkbox field (#239)

* Convert patient condition field to checkbox field

* Fix build error

* [Improvement] Add error logging, improve error handling (#240)

* Add error logging, improve error handling

* Replace GraphQL hooks with custom implementation

* [Feature] Build privacy policy and terms and conditions pages (#241)

* Create privacy policy and ToC pages

* Fix links in ToC pages

* [Fix] Fix replacement application expiry date (#242)

* [Fix] Disable GraphQL playground in production (#244)

* [Fix] Remove GQL playground redirect (#245)

* [Improvement] Various fixes (#246)

* [Fix] Fix homepage RCD emails (#247)

* [Fix] Get most recent permit by latest expiry date (#248)
OustanDing added a commit that referenced this pull request Aug 10, 2022
@OustanDing
[Release] Version 0.0.3 (#251)
8f1a983 
* [Fix] Various bug fixes (#236)

* [Fix] Prevent RCD email from breaking into two lines (#237)

* [Feature] Add date of birth filter to permit holders page (#238)

* [Fix] Convert patient condition field to checkbox field (#239)

* Convert patient condition field to checkbox field

* Fix build error

* [Improvement] Add error logging, improve error handling (#240)

* Add error logging, improve error handling

* Replace GraphQL hooks with custom implementation

* [Feature] Build privacy policy and terms and conditions pages (#241)

* Create privacy policy and ToC pages

* Fix links in ToC pages

* [Fix] Fix replacement application expiry date (#242)

* [Fix] Disable GraphQL playground in production (#244)

* [Fix] Remove GQL playground redirect (#245)

* [Improvement] Various fixes (#246)

* [Fix] Fix homepage RCD emails (#247)

* [Fix] Get most recent permit by latest expiry date (#248)

* [Fix] Fix various applications issues (#250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carelynntsai carelynntsai Awaiting requested review from carelynntsai

Assignees
No one assigned
Labels
ready to merge ✅ Ready to merge (all reviews received)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@OustanDing