Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for changes suggested to Units task in Upstream PR. #86

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

RashmikaReddy
Copy link

[https://github.com/Ciela-Institute/pull/162]Upstream PR
Issue - [https://github.com//issues/53]

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (docstrings2@194a6c7). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             docstrings2      #86   +/-   ##
==============================================
  Coverage               ?   92.41%           
==============================================
  Files                  ?       40           
  Lines                  ?     2135           
  Branches               ?        0           
==============================================
  Hits                   ?     1973           
  Misses                 ?      162           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RashmikaReddy RashmikaReddy marked this pull request as ready for review February 23, 2024 19:28
Copy link
Member

@uwcdc uwcdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RashmikaReddy I only saw 1 place that needed updates. You can accept the suggested change, so I can approve it.

Co-authored-by: Cordero Core <127983572+uwcdc@users.noreply.github.com>
@uwcdc uwcdc merged commit ec3c17d into uw-ssec:docstrings2 Feb 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants