-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: scripts/VISS_Sample_Data.R #24
refactor: scripts/VISS_Sample_Data.R #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks really good, mostly need to address the warnings and I have the question about exporting the core functions.
@@ -1,4 +1,25 @@ | |||
# Generated by roxygen2: do not edit by hand | |||
|
|||
export("%>%") | |||
importFrom(dplyr,across) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we be also exporting the main package functions here? E.g. exposure
, exposure_times
, etc?
R/exposure_times.R
Outdated
#' @return A tibble with exposure and de-exposure times | ||
#' @importFrom dplyr filter pull | ||
#' @importFrom tibble tibble | ||
exposure_times <- function(data, original.state, consecutive.elements) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you look into all these warnings?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
===========================================
- Coverage 100.00% 0.80% -99.20%
===========================================
Files 1 6 +5
Lines 1 124 +123
===========================================
Hits 1 1
- Misses 0 123 +123 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
I am currently facing an issue where no linting warnings appear when I test the package locally using However, when I push the changes to GitHub, the CI workflow still reports linting warnings, particularly related to missing global function definitions (e.g., %>%, tibble, pull). Despite matching the local linter configuration to the one used in GitHub Actions, I am unable to reproduce these warnings locally, making it challenging to debug effectively. Any insights on what might be causing this discrepancy or suggestions on how to proceed would be greatly appreciated! Thanks! |
Added an issue for tracking the warnings issue here: #38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The warnings will be addressed in #38
This pull request includes several significant updates to the project, primarily focusing on importing new dependencies, adding new functions for climate data analysis, and updating the documentation. Below is a summary of the most important changes:
Dependency Updates:
DESCRIPTION
file:dplyr
,purrr
,sf
,tibble
,terra
,exactextractr
,future
, andfurrr
.NAMESPACE
file to import functions from the new dependencies.Documentation Updates:
exposure
,exposure_times
,extract_climate_data
,get_niche_limits
, andprepare_range
. [1] [2] [3] [4] [5]Miscellaneous:
R/globals.R
to avoid R CMD check warnings.- Modularized key functions (prepare_range, extract_climate_data, get_niche_limits, exposure, exposure_times
) and moved them to the/R
folder for better code reuse and maintainability.scripts/VISS_Sample_Data.R
to orchestrate the workflow, including range preparation, climate data extraction, thermal niche limit computation, exposure calculation, and exposure times analysis.Addressing: #22