Cleanup scons mess #246
Cleanup scons mess #246
Conversation
| type='choice', | ||
| choices=("arm", "x86"), | ||
| default='arm', | ||
| help="Specifies target platform. One of 'arm' or 'x86'. Defaults to 'arm' if not provided." |
There was a problem hiding this comment.
--platform=... is now checked by scons (optparse) to make sure it's either x86 or arm
| '--library', '--project', '--smoke', '--python', '--py', | ||
| type="string", dest="name", | ||
| action='callback', callback=set_target, | ||
| help="Specify the target. e.g. --library=ms-common, --project=leds, --smoke=adc, --python=example", |
There was a problem hiding this comment.
--library=... / --project=... is now a single option that stores the target in to TARGET.
| '--name', | ||
| dest='name', | ||
| '--task', | ||
| dest='task', | ||
| type='string', | ||
| action='store' |
There was a problem hiding this comment.
changed the option for create new task to scons new --project=... --task=task_name
| type='string', | ||
| action='store', | ||
| action='store_true', | ||
| help="(arm) Reports the memory space after a build." |
There was a problem hiding this comment.
--mem-report sets mem-report instead of having to specify --mem-report=1
| type='choice', | ||
| choices=("asan", "tsan"), | ||
| default="none", | ||
| help="(x86) Specifies the sanitizer. One of 'asan' for Address sanitizer or 'tsan' for Thread sanitizer. Defaults to none." |
There was a problem hiding this comment.
update sanitizer argument to a choice
| @@ -1,55 +1,50 @@ | |||
| #include <stdio.h> | |||
There was a problem hiding this comment.
everything in smoke/... is just result of formatting. (smoke project were not formatted/linted before), there are no changes
| *can_board_ids.h | ||
| *can_codegen.h |
There was a problem hiding this comment.
these all reside in build/ folder, already ignored
There was a problem hiding this comment.
Yeah they weren't before while I was testing. It's fine to get rid of them
| *can_board_ids.h | ||
| *can_codegen.h |
There was a problem hiding this comment.
Yeah they weren't before while I was testing. It's fine to get rid of them
| uint8_t icom0 : 4; | ||
| uint8_t d0 : 8; | ||
| uint8_t fcom0 : 4; | ||
| uint16_t icom0 : 4; |
There was a problem hiding this comment.
This shouldn't matter right? Since we're putting them to be 4 bits right?
There was a problem hiding this comment.
I believe the compiler was complaining about the uint8_t d0 : 8; packing 8 bits with 8 bits. since we are only using 4 bits, it doesn't matter as the packed output is the same
We discovered there is an issue with this. I don't think we should merge this until all scons commands have been verified, so shi cheng will be responsible for testing scons flash and other commands |
No description provided.