SPI Validation #241
Merged
SPI Validation #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellostler
commented
Jan 2, 2024
| @@ -241,6 +241,11 @@ if PLATFORM == 'arm' and TYPE == 'project': | |||
|
|
|||
| # flash the MCU using openocd | |||
| def flash_run(target, source, env): | |||
| import serial | |||
There was a problem hiding this comment.
I want to merge this one in, but this check for the serial path will prevent macs from flashing. We can add a
import platform
if platform.system() == 'Darwin':
# check for /dev/tty.usbmodem* device
else:
# check for /dev/serial/
And that should resolve. Unfortunately I don't have a dongle, so I can't test at the moment
There was a problem hiding this comment.
We could also move this to another PR if you like
There was a problem hiding this comment.
I think you can just add this in
mitchellostler
commented
Jan 2, 2024
libraries/ms-common/src/arm/spi.c
Outdated
| SPI_I2S_ITConfig(s_port[spi].base, SPI_I2S_IT_ERR | SPI_I2S_IT_TXE, ENABLE); | ||
| SPI_Cmd(s_port[spi].base, ENABLE); | ||
| // set spi CS state LOW | ||
| gpio_set_state(&s_port[spi].cs, GPIO_STATE_LOW); |
There was a problem hiding this comment.
- SPI_Cmd(s_port[spi].base, ENABLE);
- // set spi CS state LOW
- gpio_set_state(&s_port[spi].cs, GPIO_STATE_LOW);
I had to change it to this on my branch so that the spi cmd happens before the pin state gets set to get the correct behaviour for the CS pin
JarvisWeng
approved these changes
Jan 17, 2024
| @@ -241,6 +241,11 @@ if PLATFORM == 'arm' and TYPE == 'project': | |||
|
|
|||
| # flash the MCU using openocd | |||
| def flash_run(target, source, env): | |||
| import serial | |||
There was a problem hiding this comment.
I think you can just add this in
| @@ -49,9 +49,7 @@ StatusCode mppt_init(const SpiSettings *settings, const SpiPort port) { | |||
| status_ok_or_return(prv_select_mppt(i)); | |||
|
|
|||
| // Turning on MPPT | |||
| status_ok_or_return(spi_cs_set_state(mppt_spi_port, GPIO_STATE_LOW)); | |||
There was a problem hiding this comment.
Do we just want to get rid of any unneeded changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.