Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace underscored commands with dasherized commands #11

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Replace underscored commands with dasherized commands #11

merged 1 commit into from
Apr 26, 2019

Conversation

cmitz
Copy link
Contributor

@cmitz cmitz commented Feb 2, 2019

Implements #10 .

I really have no experience in python stuff and it might be better to just use proper versioning, but for now this will have to do.

@Dog
Copy link

Dog commented Feb 2, 2019

Good job finding that breaking change with click.

I think pinning the versions would be a good idea to do in this file:
https://github.com/uw-ipd/github-checks-buildkite-plugin/blob/master/ghapp/requirements.txt#L1

If you'd like to do it as well you can find more information on it here:
https://pip.readthedocs.io/en/1.1/requirements.html#the-requirements-file-format

The final say would be up to the maintainers.

@cmitz
Copy link
Contributor Author

cmitz commented Feb 4, 2019

Thanks. Unfortunately, I do not have the time to make extra commits, because I have plenty of work left to do in the other parts of our Buildkite pipeline stuff.

@asford
Copy link
Member

asford commented Feb 8, 2019

Yikes, that is a rather nasty change between click 6->7, pinning makes the most sense to me. @Dog would you be willing to open PR for that?

@asford asford merged commit f6379b0 into uw-ipd:master Apr 26, 2019
asford pushed a commit that referenced this pull request Apr 26, 2019
(See #11 for partial #15 fix.) 

Fix use of double in jwt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants