ls: finish the plug of mtime #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
Marked as passed! |
sylvestre
force-pushed
the
ls-mtime
branch
2 times, most recently
from
a296b36 to
48bec57
Compare
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
cakebaker
reviewed
Dec 31, 2024
cakebaker
reviewed
Dec 31, 2024
tests/by-util/test_ls.rs
Outdated
Comment on lines
2108
to
2111
| let f = at.make_file("test-3"); | ||
| f.set_modified(SystemTime::now()).unwrap(); | ||
| let f = at.make_file("test-4"); | ||
| f.set_modified(SystemTime::now()).unwrap(); |
There was a problem hiding this comment.
I would give those vars a different name than f. It should allow you to get rid of the make_file calls on lines 2119 and 2122.
There was a problem hiding this comment.
well done, thanks again :)
|
GNU testsuite comparison: |
Will help with tests/ls/ls-time
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help with tests/ls/ls-time