Change the git pre-commit actions to work on stable. #6715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not being fixed, so it does not make sense to constantly take on new lints. The fmts may never be stabilized. Currently, you can not even commit, because it errors out. At least switch to lints that make it to stable when they are released.
|
For some reason it runs on all files not just the ones in the commit. |
|
Makes sense |
BenWiederhake
added a commit
to BenWiederhake/coreutils-rs
that referenced
this pull request
Sep 30, 2024
This is in response to uutils#6715: e8bb8df The pre-commit actions have a higher MSRV than the overall project (1.70.0), so if 1.70.0 is the configured default, this lead to problems (uutils#6730). This commit fixes the situation by specifying 'stable', whatever that means on the user's system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are not being fixed, so it does not make sense to constantly take on new lints. The fmts may never be stabilized. Currently, you can not even commit, because it errors out. At least switch to lints that make it to stable when they are released.