-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cksum: accept non-UTF-8 filenames #6575
cksum: accept non-UTF-8 filenames #6575
Conversation
af3e60c
to
24c8b99
Compare
CI failures are unrelated issues:
|
ed05338
to
5b82c63
Compare
Changes since initial push:
|
415c1f7
to
3c949a7
Compare
Changes since last push description:
|
26957a3
to
a3efe5b
Compare
Changes since last push description:
Remaining CI failures are unrelated:
|
66112fb
to
3d5232b
Compare
Changes since last push description:
|
src/uu/cksum/src/cksum.rs
Outdated
"{} {}", | ||
sum.parse::<u16>().unwrap(), | ||
div_ceil(sz, options.output_bits) | ||
let (before_filename, print_filename, after_filename) = match (options.algo_name, not_file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The print_filename
var name is a bit misleading and I was surprised it's of type bool
. I expected it to be a String
, like the other two vars. My suggestion is to rename it to something like should_print_filename
.
3d5232b
to
4c9cd6e
Compare
GNU testsuite comparison:
|
4c9cd6e
to
0119cc1
Compare
Changes since (my?) last push:
|
0119cc1
to
1fcff25
Compare
Changes since last push:
|
Thanks :) |
Fixes #6574.
Example: