Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy errors #6505

Merged
merged 4 commits into from
Jun 30, 2024
Merged

Fix clippy errors #6505

merged 4 commits into from
Jun 30, 2024

Conversation

Its-Just-Nans
Copy link
Contributor

@Its-Just-Nans Its-Just-Nans commented Jun 28, 2024 •
edited
Loading

Follow and fix #6504

@Its-Just-Nans Its-Just-Nans mentioned this pull request Jun 28, 2024
Closed
@sylvestre
Copy link
Contributor

All the warnings will need to be fixed before it can be merged

@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

sylvestre
sylvestre reviewed Jun 28, 2024
View reviewed changes
src/bin/coreutils.rs Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@Its-Just-Nans Its-Just-Nans requested a review from sylvestre June 28, 2024 13:39
@sylvestre
Copy link
Contributor

sylvestre commented Jun 29, 2024 •
edited
Loading

this can not be squashed because i would like:

  • one commit to enable new clippy warnings
  • one or several commits to fix them
    please rewrite the stack
    (git rebase -i origin/main is your friend)

sylvestre
sylvestre reviewed Jun 29, 2024
View reviewed changes
tests/by-util/test_cp.rs Outdated Show resolved Hide resolved
@sylvestre
Copy link
Contributor

I pushed that fix: cac18fb

@sylvestre
Copy link
Contributor

sylvestre commented Jun 30, 2024 •
edited
Loading

Screenshot_20240630_161136_Firefox Nightly

Could you please rewrite the stack commit message ? Thanks

@Its-Just-Nans
Copy link
Contributor Author

Screenshot_20240630_161136_Firefox Nightly

Could you please rewrite the stack commit message ? Thanks

Yes yes, you're so fast ahah.
I was waiting for the CI/CD to finish ^^

@Its-Just-Nans Its-Just-Nans requested a review from sylvestre June 30, 2024 16:45
@sylvestre sylvestre merged commit 9c0f2f8 into uutils:main Jun 30, 2024
67 of 68 checks passed
@sylvestre
Copy link
Contributor

thanks

@Its-Just-Nans Its-Just-Nans deleted the fix-clippy-errors branch June 30, 2024 17:27
@BrewTestBot BrewTestBot mentioned this pull request Nov 16, 2024
Merged
@moonfruit moonfruit mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre Awaiting requested review from sylvestre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Its-Just-Nans @sylvestre