-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use -pcoreutils
when running clippy
#6247
ci: use -pcoreutils
when running clippy
#6247
Conversation
b58484b
to
92ee1f3
Compare
Changes since last push:
|
92ee1f3
to
7c1232c
Compare
Changes since last push:
|
matrix.job.cargo-options
instead of using -putil_1 -putil2 etc.
7c1232c
to
f2ffb78
Compare
Changes since last push:
|
matrix.job.cargo-options
-pcoreutils
when running clippy
Changes since last push:
|
79e370d
to
de08536
Compare
Changes since last push:
|
de08536
to
347a387
Compare
Changes since last push:
|
GNU testsuite comparison:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it says on the tin, and evidently you "tested" it by finding actual problems in the code. Yay! :)
Do you know why the Windows CI fails? This doesn't look like a flake:
$ cargo nextest run --profile ci --hide-progress-bar --features=windows -p uucore -p coreutils
<SNIP downloading and compiling>
Compiling rstest v0.19.0
Compiling unindent v0.2.1
Compiling hex-literal v0.4.1
Finished `test` profile [unoptimized + debuginfo] target(s) in 1m 56s
error: creating test list failed
Caused by:
for `coreutils::bin/coreutils`, command `'D:\a\coreutils\coreutils\target\debug\deps\coreutils-08f81a256ac17834.exe' --list --format terse` exited with code 0xc0000135: The specified module could not be found. (os error 126)
--- stdout:
--- stderr:
---
Error: Process completed with exit code 1.
@BenWiederhake it looks like it was a temporary issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks still good 👍
While looking at #6246 I wondered why those clippy warnings were not caught by our CI.
The reason is probably that${{ matrix.job.cargo-options }}
is never defined and so I replaced it with${{ steps.vars.outputs.CARGO_FEATURES_OPTION }}
.I couldn't figure out the reason and my two attempts to make the CI fail on those warnings failed. And so this PR is just about removing the undefinedIt looks like the reason is that we select the utils for the specific platform and then run clippy on those packages (which don't contain the tests). By running clippy on the${{ matrix.job.cargo-options }}
.coreutils
package with the--features
flag, the tests are also checked by clippy.