-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made cksum return an error if used on a directory. #5822
Conversation
… of the algorithm
Couldn't make the last test work by creating a temporary path + directory, so I used one already existing. |
Sorry, a rebase is needed :| For creating a temporary directory in
|
…expected it to succeed instead of fail
Should be ok now I think, let me know if I need to do anything else. |
Thanks! It's almost complete, though there is still an issue with the example from #5805 if more than one item is specified. The |
Wouldn't that be automatically solved when #5809 is merged? |
No, #5809 is about showing an error when a specified file doesn't exist, whereas this PR is about showing an error when a directory is specified. |
My bad, I understand.Should be ready now. |
GNU testsuite comparison:
|
Thanks! |
This PR should fix #5805. Now an error is generated if
cksum
is used on a directory and it returns an exit code of1
.