Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ls: set correct block size when -k is provided #5700

Merged
merged 1 commit into from
Dec 25, 2023
Merged

ls: set correct block size when -k is provided #5700

merged 1 commit into from
Dec 25, 2023

Conversation

cakebaker
Copy link
Contributor

This PR sets the correct block sizes when -k is provided. It makes https://github.com/coreutils/coreutils/blob/master/tests/ls/block-size.sh pass

@cakebaker cakebaker marked this pull request as draft December 23, 2023 16:34
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/block-size is no longer failing!

@sylvestre
Copy link
Contributor

Congrats! The gnu test tests/ls/block-size is no longer failing!

kudos

@sylvestre
Copy link
Contributor

but fails on:

--- TRY 3 STDERR:        coreutils::tests test_ls::test_ls_allocation_size ---
thread 'test_ls::test_ls_allocation_size' panicked at ''total 4096
   0 empty-file
   0 file-with-holes
4096 zero-file
' does not contain 'total 1024'', tests/by-util/test_ls.rs:251:14

@sylvestre sylvestre force-pushed the ls_block_size_with_k branch from 6fc2046 to c67cf2f Compare December 23, 2023 18:42
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/block-size is no longer failing!

@cakebaker cakebaker force-pushed the ls_block_size_with_k branch from c67cf2f to 270ac90 Compare December 24, 2023 15:35
@github-actions GitHub Actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/ls/block-size is no longer failing!

@cakebaker cakebaker marked this pull request as ready for review December 24, 2023 16:09
@sylvestre sylvestre merged commit 840a5bf into uutils:main Dec 25, 2023
55 of 57 checks passed
@cakebaker cakebaker deleted the ls_block_size_with_k branch December 25, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @sylvestre