Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

du: call unused _du_basics() in test_du_basics() #5503

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

cakebaker
Copy link
Contributor

While looking at the du tests I noticed that the _du_basics functions are never called. Assuming they were intended to be called from test_du_basics, I adapted this function accordingly.

@cakebaker cakebaker marked this pull request as draft November 6, 2023 08:47
Copy link

github-actions bot commented Nov 6, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail/retry is no longer failing!
Congrats! The gnu test tests/tail/symlink is no longer failing!

@cakebaker cakebaker force-pushed the du_unused_du_basics branch 2 times, most recently from be3b0ce to 03095c5 Compare November 6, 2023 10:05
Copy link

github-actions bot commented Nov 6, 2023

GNU testsuite comparison:

Congrats! The gnu test tests/tail/retry is no longer failing!

@cakebaker cakebaker force-pushed the du_unused_du_basics branch from 03095c5 to 48d6d25 Compare December 2, 2023 14:28
@cakebaker cakebaker force-pushed the du_unused_du_basics branch from 48d6d25 to 4903b91 Compare December 2, 2023 15:52
@cakebaker cakebaker marked this pull request as ready for review December 3, 2023 13:54
@sylvestre sylvestre merged commit 6d2486c into uutils:main Dec 25, 2023
51 of 53 checks passed
@cakebaker cakebaker deleted the du_unused_du_basics branch December 26, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants