Refactor signal handling in yes, tee, and timeout

[anastygnome]

Edit : Original title was "yes: remove redundant dependency"

Yes, using libc while using nix was a bit redundant.

[sylvestre]

I wonder if we could write something (clippy extension?) to detect this kind of pattern

[tertsdiepraam]

I wonder if we could write something (clippy extension?) to detect this kind of pattern

I've been thinking about whether could get rid of using libc directly. It should be fairly easy to track if we remove the libc re-export from uucore and just check which utils mention libc in the Cargo.toml. nix covers most cases where we currently use libc and we could contribute missing functionality to nix directly. Like I've done here: nix-rust/nix#1805

[anastygnome]

The CI fails on 66f6d22 seem unrelated. Can you take a look @tertsdiepraam, looks like a touch issue and some weird syscalls thing on android.

[tertsdiepraam]

Yeah the touch issue is known and the android issue seems unrelated.

[anastygnome]

I'll also take a look at

coreutils/src/uu/tee/src/tee.rs

Line 154 in 9090dd7

fn enable_pipe_errors() -> Result<()> {

and

coreutils/src/uu/timeout/src/timeout.rs

Line 289 in 9090dd7

fn enable_pipe_errors() -> std::io::Result<()> {

[anastygnome]

@tertsdiepraam thanks for the review. Should I put this function in uucore as it is duplicated three times over?

[tertsdiepraam]

Should I put this function in uucore as it is duplicated three times over?

Yeah I think that makes sense

[anastygnome]

@sylvestre gnu git mirror seems unavailable.
@tertsdiepraam This prevents the tests

[tertsdiepraam]

The CI now seems to work. We'll check in later with the GNU test suite.

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/cp/cp-i is no longer failing!
Congrats! The gnu test tests/cp/debug is no longer failing!
Congrats! The gnu test tests/du/apparent is no longer failing!
Congrats! The gnu test tests/misc/cksum-base64 is no longer failing!
Congrats! The gnu test tests/misc/cksum-raw is no longer failing!
Congrats! The gnu test tests/misc/tee is no longer failing!
Congrats! The gnu test tests/misc/wc-total is no longer failing!
Congrats! The gnu test tests/mv/i-1 is no longer failing!
Congrats! The gnu test tests/mv/i-5 is no longer failing!
GNU test failed: tests/cp/sparse-perf. tests/cp/sparse-perf is passing on 'main'. Maybe you have to rebase?

[tertsdiepraam]

Those failing GNU test might be due to the bump to GNU coreutils 9.2, you probably don't need to worry about them.

[anastygnome]

hmm?

the trait uucore::error::UError is not implemented for `nix::errno::Errno

ah seems like most of UError is only implemented for linux and android

Any issue on mac though?

[github-actions]

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

[tertsdiepraam]

That's unfortunate. I think nix should work for all unix platform, so feel free to change the cfg.

[anastygnome]

The errors seem unrelated to this PR

[github-actions]

GNU testsuite comparison:

GNU test failed: tests/tail-2/inotify-dir-recreate. tests/tail-2/inotify-dir-recreate is passing on 'main'. Maybe you have to rebase?

[tertsdiepraam]

I like it! Let's get this merged.