Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comm: implement --zero-terminated #4449

Merged
merged 1 commit into from
Mar 1, 2023
Merged

comm: implement --zero-terminated #4449

merged 1 commit into from
Mar 1, 2023

Conversation

cakebaker
Copy link
Contributor

This PR implements the --zero-terminated option. It makes the tests zbasic, zopt-1 - zopt-3, zopt-12, zopt-13, zopt-23, totalz-all, and totalz-123 in https://github.com/coreutils/coreutils/blob/master/tests/misc/comm.pl pass.

@cakebaker cakebaker force-pushed the comm_zero_terminated branch from c5b3867 to e2f9786 Compare March 1, 2023 09:15
tertsdiepraam
tertsdiepraam reviewed Mar 1, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

src/uu/comm/src/comm.rs Show resolved Hide resolved
src/uu/comm/src/comm.rs Outdated Show resolved Hide resolved
@cakebaker cakebaker force-pushed the comm_zero_terminated branch from e2f9786 to 0d782e0 Compare March 1, 2023 16:00
@tertsdiepraam tertsdiepraam merged commit b9bca79 into uutils:main Mar 1, 2023
@tertsdiepraam
Copy link
Member

Thanks!

@cakebaker cakebaker deleted the comm_zero_terminated branch March 2, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cakebaker @tertsdiepraam