Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch: move help strings to a markdown file #4373

Merged
merged 8 commits into from
Feb 22, 2023
Merged

arch: move help strings to a markdown file #4373

merged 8 commits into from
Feb 22, 2023

Conversation

zleyyij
Copy link
Contributor

@zleyyij zleyyij commented Feb 15, 2023

This change moves the about and summary help strings to arch.md in the arch directory

@zleyyij
Copy link
Contributor Author

zleyyij commented Feb 15, 2023

#4368
mentioning the relevant issue

@zleyyij zleyyij changed the title arch: move help strings to a markdown file #4368 arch: move help strings to a markdown file Feb 15, 2023
tertsdiepraam
tertsdiepraam reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@tertsdiepraam tertsdiepraam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks! I have a few small suggestions.

src/uu/arch/arch.md Outdated Show resolved Hide resolved
src/uu/arch/src/arch.rs Outdated Show resolved Hide resolved
src/uu/numfmt/numfmt.md Outdated Show resolved Hide resolved
src/uu/arch/arch.md Outdated Show resolved Hide resolved
@zleyyij
Copy link
Contributor Author

zleyyij commented Feb 15, 2023

All those changes have been applied, thank you for the feedback :)

sylvestre
sylvestre reviewed Feb 17, 2023
View reviewed changes
src/uu/arch/src/arch.rs Outdated Show resolved Hide resolved
tertsdiepraam
tertsdiepraam reviewed Feb 19, 2023
View reviewed changes
src/uu/arch/arch.md Outdated Show resolved Hide resolved
src/uu/numfmt/numfmt.md Outdated Show resolved Hide resolved
@zleyyij
Copy link
Contributor Author

zleyyij commented Feb 21, 2023

Those changes should be applied, I remembered to use rustfmt :)

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/tail-2/inotify-dir-recreate is no longer failing!

@tertsdiepraam
Copy link
Member

Thanks!

@tertsdiepraam tertsdiepraam merged commit b70131f into uutils:main Feb 22, 2023
@tertsdiepraam tertsdiepraam mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre left review comments

@tertsdiepraam tertsdiepraam tertsdiepraam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zleyyij @tertsdiepraam @sylvestre