tr: Remove the extra newline in stderr #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howjmay
changed the title
|
GNU testsuite comparison: |
jfinkels
approved these changes
Feb 14, 2023
| } | ||
| Self::MultipleCharRepeatInSet2 => { | ||
| writeln!(f, "only one [c*] repeat construct may appear in string2") | ||
| write!(f, "only one [c*] repeat construct may appear in string2") |
There was a problem hiding this comment.
The code coverage tool says that line 45 and line 48 are not covered by our tests. This is good as is, but if you feel up to it, it would be nice to add two more tests to the test_tr.rs file, one for each of these.
There was a problem hiding this comment.
Ah I am having problems to understand the error messages. I am glad to add tests to cover the errors, but I need your help to explain the errors. Otherwise I don't really have idea how to trigger them
There was a problem hiding this comment.
Here are two invocations that trigger these errors:
tr '[a*]' 'a'
tr 'a' '[a*][a*]'
|
GNU testsuite comparison: |
|
Thank you too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4301