uucore: add sprintf() function #4185
Conversation
sylvestre
force-pushed
the
uucore-sprintf-2
branch
from
1b92cf5 to
2cb513d
Compare
|
GNU testsuite comparison: |
| /// any subst. arguments along the way. | ||
| /// 2. feeds remaining arguments into function | ||
| /// that prints tokens. | ||
| struct Memo { |
There was a problem hiding this comment.
I guess unrelated to this particular PR, but I don't understand why this is called Memo? Is it like a memoization of the token string?
The same goes for the fact that printf and sprintf are exposed via the memo module at the moment, instead of something (imo) more appropriate like uucore::format or uucore::print
There was a problem hiding this comment.
I'm not sure why it is called Memo, I assumed it had something to do with memoization as well. I wasn't really familiar with what this Memo struct was supposed to do when I moved it from the printf crate to the uucore crate, so I just named this module uucore::memo, but yes it should have been something like uucore::printf or something like that.
Add an `sprintf()` function (and `printf()` function) to `uucore::memo`. The `sprintf()` function behaves roughly like the standard Rust `format!()`, but follows our implementation of the GNU `printf` formatting logic instead.
sylvestre
force-pushed
the
uucore-sprintf-2
branch
from
2cb513d to
d083fa1
Compare
Add an
sprintf()function (andprintf()function) touucore::memo. Thesprintf()function behaves roughly like the standard Rustformat!(), but follows our implementation of the GNUprintfformatting logic instead. Theprintf()function is a convenience function that wraps theMemo::run_all()function in order to provide a more user-friendly name (or at least more familiar to C programmers).This pull request was inspired by this comment requesting the use of
%gto format a number indd: #4169 (comment)