sort: allow a sort mode to appear multiple times
#4132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
force-pushed
the
sort-accept-sort-mode-multiple-times
branch
from
2c2dc09 to
7a54180
Compare
A test case for this is `sort -k 2n,2n` which should be accepted, because `n` is compatible with itself. Resolves issue uutils#4129.
sylvestre
force-pushed
the
sort-accept-sort-mode-multiple-times
branch
from
7a54180 to
03c40b2
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test case for this is
sort -k 2n,2nwhich should be accepted, becausenis compatible with itself.I think the only case we were missing was the case where a mode is given twice. All other combinations are probably incompatible.
Resolves #4129.