cp: preserve permissions when copying directory and don't terminate early on inaccessible file #3973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
force-pushed
the
cp-directory-preserve-permissions
branch
3 times, most recently
from
f0a3a52 to
e44db65
Compare
Create `assert_metadata_eq!()` macro to contain a series of assertions that check whether two `Metadata` objects are equal.
Add the `AtPath.set_mode()` method that sets the permissions for a given path in the test directory.
Create a `copy_attributes()` function to contain the loop that copies each of a specified set of attributes in turn.
Make cp preserve the permissions of a directory when copying
it. Before this commit,
cp -pR src/ dest/
failed to copy the permissions of `src/` to `dest/`. After this
commit, the permissions are correctly copied.
Stop `cp` from terminating prematurely if a file in a directory is inaccesible due to insufficient permissions.
jfinkels
force-pushed
the
cp-directory-preserve-permissions
branch
from
96a5169 to
b89e8e5
Compare
|
Congrats! The gnu test tests/misc/tee is no longer failing! |
|
great work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes two related fixes to
cp.First, we make cp preserve the permissions of a directory when copying it. Before this commit,
failed to copy the permissions of
src/todest/. After this commit, the permissions are correctly copied.Second, we make stop
cpfrom terminating prematurely if a file in a directory is inaccesible due to insufficient permissions.These two changes fix on assertion in GNU test suite file
tests/cp/fail-perm.sh(but it will not be passing yet).