-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dd: fix output issues #3610
dd: fix output issues #3610
Conversation
a2b0180
to
f1e85d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
f1e85d5
to
a93aa9a
Compare
Looks like my manual merge didn't work, could you please fix it? sorry :( |
No problem @sylvestre, I've merged the current main branch into this one. |
thanks! |
@patricksjackson did you push it? |
I misunderstood, and I hadn't realized that the merge broke the tests. I've fixed the tests that were broken due to the merge and have pushed the new changes. |
this change has been documented here: (i just saw it) |
This change fixes multiple issues with the output of dd, that were easiest to complete in a single PR.
The performance uplift of fixing the overzealous thread communication is significant for small blocksizes, and stacks with the buffer changes in #3600.