mktemp: combine --tmpdir and subdirectory info
#3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
force-pushed
the
mktemp-tmpdir-subdirectory
branch
from
7b601df to
806d259
Compare
jfinkels
force-pushed
the
mktemp-tmpdir-subdirectory
branch
from
806d259 to
6d2dc10
Compare
|
After adding a test case for the situation suggested by @tertsdiepraam, I ran into a difficulty with producing the correct error messages due to how the prefix and suffix are computed. I'm going to put this back into draft status for now while I try to streamline the prefix and suffix handling code. |
Add a unit test for combining the directory given in `--tmpdir` with
any subdirectory structure appearing in the prefix of the template
string. For example,
$ mktemp --tmpdir=a b/cXXX
a/b/cNqJ
This behavior is currently working, but a unit test was missing.
jfinkels
force-pushed
the
mktemp-tmpdir-subdirectory
branch
from
6d2dc10 to
a9e008f
Compare
|
After rebasing on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the directory given in
--tmpdirwith any subdirectorystructure appearing in the prefix of the template string. For example,
Previously, this would have incorrectly exited with an error message.