ls: when -aA are provided, the order matters

[sylvestre]

No description provided.

[tertsdiepraam]

Ohh good find! Instead of manually checking the indices, we should probably make them override each other with clap's Arg::overrides_with, so we don't need to implement the logic ourselves.

[sylvestre]

it supports the order?
-aA is different than -Aa

[tertsdiepraam]

Yeah the overrides_with method makes it so that the earlier argument is automatically discarded when the second one is passed, so -aA is equivalent to -A and -Aa is equivalent to -a.

[sylvestre]

bien vu, done :)

[anastygnome]

Hey there

Yeah the overrides_with method makes it so that the earlier argument is automatically discarded when the second one is passed, so -aA is equivalent to -A and -Aa is equivalent to -a.

Nice finding @tertsdiepraam !

@sylvestre You should consider adding a comment there, as I, unfamiliar with this code , had to read this PR to understand this part of the code, and this is just using some external lib logic.

This could also be reused in other tools.

anything that's clever, or that you find surprising should be commented.

(a CS prof. of mine, back in the day)

[sylvestre]

Yeah:
Changes from main: PASS +1 / FAIL -1 / ERROR +0 / SKIP +0

[sylvestre]

@anastygnome I think it is self explanatory but as it doesn't hurt, I added comments :)

[tertsdiepraam]

Looks good, but while we're changing this, both should also override themselves (so that ls -aa is possible). @anastygnome this is a technique used throughout the codebase, but you're right that more comments never hurt anybody :)

[sylvestre]

both should also override themselves

I used .multiple_occurrences for this

[tertsdiepraam]

Sure! That's a good solution in this case. More generally, we should probably push for using https://docs.rs/clap/3.1.6/clap/struct.App.html#method.args_override_self in (almost) all utils.