-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dd: implement iseek + oseek flags #3256
Conversation
--iseek and --oseek are fairly new dd features, added in coreutils commit 4439ef3ec4 this February. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself is fine, I'm requesting some changes to the tests and eliminating some duplicate code.
These are the first half of changes needed to pass the dd/bytes.sh tests: - Add iseek and oseek options (additive with skip and seek options) - Implement tests for the new flags, matching those from dd/bytes.sh
…nfirm additive flags
I'm a bit confused by the failing GnuTests CI run- |
yeah, likely not your fault :) |
Yes, it is an intermittent issue #2924 |
Hi! I'm doing a refactor of the argument handling of This is with
|
I likewise haven't been able to reproduce the additive behavior- I probably misinterpreted the results of my tests. I've checked out the pull request, and the behavior looks to be correct now. |
These are the first half of changes needed to pass the dd/bytes.sh tests: