split: add a method to convert ArgMatches to Settings #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfinkels
force-pushed
the
split-settings-methods
branch
from
5e17b15 to
ff821a0
Compare
|
My PR is failing on the exact same GNU test. See: #2875 |
|
Yeah, don't worry about it, it's showing up on all recent PRs, so it's not your fault |
Create a `Settings::from` method that converts a `clap::ArgMatches` instance into a `Settings` instance. This eliminates the unnecessary use of a mutable variable when initializing the settings.
jfinkels
force-pushed
the
split-settings-methods
branch
from
ff821a0 to
58f2000
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
Settings::frommethod that converts aclap::ArgMatchesinstance into a
Settingsinstance. This eliminates the unnecessaryuse of a mutable variable when initializing the settings.
This does not change the behavior of
split, is just a re-organization of the code.