[: install test as [ as well #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes [ work even when installed with a custom prefix, e.g. as uu-[.
I think your approach as it is right now is a valid workaround. The manpage speaks of another subtle difference:
|
Thanks for pointing this out! Are we allowed to copy the help text from GNU, or do we have to come up with our own? |
sylvestre
reviewed
Jul 4, 2021
I copied the help text verbatim from GNU, I hope that's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2420.
This installs
testas[as well. Whentestis called with a binary name that ends with[, it changes its behavior a bit.I would rather add
[as its own utility instead of changing the behavior oftestbased on its binary name,but I ran into problems trying to do that because
[is not a valid crate/feature name. Working around it in build.rs and in GNUmakefile adds complexity and feels easy to get wrong... In any case we can't convince cargo to create a binary called[, which we can't work around ifuutilsis installed viacargo install.There are plans for cargo to support creating arbitrarily named binaries, which would mean we'd only have to work around the restriction for the feature name.
Maybe we can solve this problem in some other way?