Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm: reduce nesting in prompt_file #5345

Closed
tertsdiepraam opened this issue Oct 1, 2023 · 3 comments · Fixed by #5356
Closed

rm: reduce nesting in prompt_file #5345

tertsdiepraam opened this issue Oct 1, 2023 · 3 comments · Fixed by #5356
Labels
good first issue For newcomers! U - rm

Comments

@tertsdiepraam
Copy link
Member

tertsdiepraam commented Oct 1, 2023 •
edited
Loading

prompt_file is more complicated than it needs to be and can be cleaned up with some early returns and maybe with let-else. The behaviour should stay the same, but it needs to be cleaned up!

Note: There's more functions with a lot of nesting, I've cleaned those up already in #5344
@terade
Copy link
Contributor

terade commented Oct 4, 2023

Hello, I would like to work on this issue. Unfortunately I am inexperienced so I am sorry if I create additional work.

@cakebaker
Copy link
Contributor

@terade sure, go ahead :)

@tertsdiepraam
Copy link
Member Author

No worries, go ahead!

terade added a commit to terade/coreutils that referenced this issue Oct 4, 2023
@terade
Refactor prompt_file, lower nesting depth
a3b5718 
Addressing issue uutils#5345.
@cakebaker cakebaker linked a pull request Oct 4, 2023 that will close this issue
rm: refactor prompt_file, issue #5345 #5356
Merged
@terade terade mentioned this issue Oct 4, 2023
Merged
terade added a commit to terade/coreutils that referenced this issue Oct 5, 2023
@terade
rm: Refactor prompt_file, lower nesting depth
f18e898 
Addressing issue uutils#5345.
Introduce new helper function: prompt_file_permission_read_only
cakebaker added a commit that referenced this issue Oct 18, 2023
@cakebaker
Merge pull request #5356 from terade/refactoring_prompt_file
7a60819 
`rm`: refactor `prompt_file`, issue #5345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - rm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rm: refactor prompt_file, issue #5345 terade/coreutils
3 participants
@cakebaker @tertsdiepraam @terade