Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect count of delayed jobs in the enqueueTransaction test #217

Merged
merged 2 commits into from
Sep 2, 2024
Merged

fix: incorrect count of delayed jobs in the enqueueTransaction test #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e1969b
fix: incorrect count of delayed jobs in the TransactionProcessor.enqu…
ShookLyngs Sep 2, 2024
fd4d2be
chore: upgrade dependencies in the test ci
ShookLyngs Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ jobs:

steps:
- name: Checkout Code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Install PNPM
uses: pnpm/action-setup@v3
uses: pnpm/action-setup@v4
with:
version: 8
version: 9

- name: Use Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: "21"
cache: "pnpm"
Expand Down
13 changes: 8 additions & 5 deletions test/services/transaction.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,14 @@ describe('transactionProcessor', () => {
},
};

transactionProcessor.enqueueTransaction(transactionRequest);
const count = await transactionProcessor['queue'].getJobCounts();
const job = await transactionProcessor['queue'].getJob(transactionRequest.txid);
expect(count.delayed).toBe(1);
expect(job?.delay).toBe(cradle.env.TRANSACTION_QUEUE_JOB_DELAY);
await transactionProcessor.enqueueTransaction(transactionRequest);
const jobs = await transactionProcessor['queue'].getJobs('delayed');
const jobFromApi = await transactionProcessor['queue'].getJob(transactionRequest.txid);
const jobFromList = jobs.find((row) => row.id === transactionRequest.txid);

expect(jobFromApi).toBeDefined();
expect(jobFromApi!.id).toStrictEqual(jobFromList?.id);
expect(jobFromApi!.delay).toBe(cradle.env.TRANSACTION_QUEUE_JOB_DELAY);
});

test('retryMissingTransactions: should be retry transaction job when missing', async () => {
Expand Down