Split core into core, api and extension modules #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedNaru
force-pushed
the
feature/split-core-and-api
branch
from
7c70991 to
45cf775
Compare
CedNaru
requested review from
piiertho and
chippmann
and removed request for
piiertho
piiertho
reviewed
Feb 2, 2025
| @@ -120,4 +130,46 @@ class ClassService( | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| override fun findEnumValue(enumClassName: ClassTypeNameWrapper, enumValue: Long): DefaultEnumValue { | |||
There was a problem hiding this comment.
I would rename findEnumValue to findDefaultEnumValue
piiertho
previously approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The godot library is now split into several modules with the following stack each depending on the previous ones:
Api now purely contains generated code. It will make the custom api generator much easier to implement as we will only need to swap our default one with a local, created by the users.
I'll probably make another PR on that matter. So far I have focused on making the split functional, but there is a bit of cleaning to do. This PR is already big enough so I'll leave that for later.
Don't be scared by the number of files, most of them are just moved to different directory. 90% of the changes are in the gradle scripts and the API generation.