Add tests for listContents endpoint #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldadfux
reviewed
May 2, 2024
| return array_map(static function ($item) { | ||
| return $item['name']; | ||
| }, $response['body']); | ||
| if (isset($response['body'][0])) { |
There was a problem hiding this comment.
What is the data that we expect here? is it possible that sometime we'll get it as array and sometimes as an object?
There was a problem hiding this comment.
If you enter a path like src, it returns an array of arrays with each file/ folder details.
If you enter an absolute path of a file like README.md, it returns an array with the details of the file, instead of array of array.
If you enter a path that has no files, like an empty repo, it returns an empty array.
eldadfux
approved these changes
May 2, 2024
Co-authored-by: Christy Jacob <christyjacob4@gmail.com>
christyjacob4
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.